modules: delete stop-loss example subsumed by composablecow monitor - #570
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Delete the
stop-lossexample module: crate, workspace member,Cargo.lockentry, everyengine.*.tomlinstall, the CI guest-wasm build list, the justfile, and docs that named it. Guest-wasm count drops from 18 to 17.Why
The module hand-rolled its own
submitted:{id}dedup againsthost.get/host.setand built an unsigned pre-sign order on a path the generic ComposableCoW monitor already covers, leaving a second divergent copy of submit-and-dedup logic. Removing it also clears the worst collision seam for the M4/M3 follow-up waves (#538, #545, #546, #522, #544), which all touchedstop-loss/src/strategy.rs.Testing
Full battery under
nix develop, every step exit 0:cargo fmt --check;cargo clippy --workspace --all-targets --all-features --locked -D warnings; wasm release build of the 16 remaining modules pluscow-venue --features adapter,ls target/wasm32-wasip2/release/*.wasm | wc -l== 17;cargo nextest run --workspace --all-features --no-fail-fast --locked(792 passed, 1 skipped);cargo test --doc;RUSTDOCFLAGS=-D warnings cargo doc --no-deps;check-venue-agnostic.sh;check-cow-orderbook-only.sh.AI Assistance
Implemented with Claude Code.
Closes #568